On Wed, Jan 13, 2016 at 02:44:25PM +0100, Pilisi Gergely wrote: > Hi, > > the new package is available on the mentors site: ok, new iteration :) 1) Well, I'm conviced that --verbose passed to dh is not what I had in mind with "verbose building". I still see (C++) Object.cc (CC) record.c (C++) OCSV.cc (CC) record_of.c (CC) union.c (C++) Tag.cc (C++) PredefFunc.cc (C++) TableConstraint.cc (C++) AST.cc (C++) TokenBuf.cc that's ↑ not's verbose at all. Here's an hint for you: this a makefile-based project. to have GNU make be more verbose, is enough to export V=1. This gave me indeed a verbose output of compilation flags, but somehow the build failed this way (??). It's very easy to make this program fail to build, feel fragile... 2) hardening-wrapper can just go away, the package builds fine anyway. The canonical way to have hardening buildflags is to export DEB_BUILD_MAINT_OPTIONS=hardening=+all in d/rules (instead of DEB_BUILD_HARDENING). Having a look at Makefile.cfg I see: * CFLAGS ain't used (instead there is a CCFLAGS variable); * CXXFLAGS ignores the external env. You may need to patch it a bit. 3) please fix the following lintian warnings: W: eclipse-titan: script-with-language-extension usr/bin/ttcn3_archive.pl I: eclipse-titan: package-contains-empty-directory usr/share/titan/etc/asciiart/ W: eclipse-titan: manpage-has-errors-from-man usr/share/man/man1/ttcn3_logfilter.1.gz 11: warning: macro `..' not defined W: eclipse-titan: manpage-has-errors-from-man usr/share/man/man1/ttcn3_logformat.1.gz 54: a space character is not allowed in an escape name W: eclipse-titan: executable-not-elf-or-script usr/bin/ttcn3_archive.pl 4) there are a bunch of debug-file-with-no-debug-symbols and that postinst-has-useless-call-to-ldconfig that makes me itch. I feel there is something weird going on, but I wouldn't know what it is. 5) do you even look at what lintian says on mentors? I: eclipse-titan source: wildcard-matches-nothing-in-dep5-copyright mctr2/editline (paragraph at line 5) I: eclipse-titan source: unused-file-paragraph-in-dep5-copyright paragraph at line 5 the order of the paragraphs in d/copyright is important. the wildcard in the second paragraph overrides the first. so you need to swap them. Furthermore I don't see a paragraph for debian/, as I can read it now the copyright for debian/* is of "Ericsson Telecom AB". -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: http://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature