Bug#808441: RFS: rfcdiff/1.42-1 ITP
Hey Mattia!
Thanks again for taking the time.
On 12/21/2015 12:04 AM, Mattia Rizzolo wrote:
> wrap-and-sort doesn't touch debian/rules.
> Also, in this process you added new trailing whitespaces (`git diff`
> (and friends, like `git log -p` and `git show`) shows them in red
> here...)
>
I did not know about that. I've gone over the manpages of wrap-and-sort.
Thanks for pointing that out.
Do you know some sort of command which lists me all occurrences of
trailing whitespaces?
> debian/patches/fix-changelog-typos.patch:1
> debian/patches/fix-changelog-typos.patch:2
> debian/patches/fix-fsf-address.patch:2
>
Fixed
>>> there is really no need to do that useless
>>> override_dh_auto_install, just empty that target in d/rules, and
>>> write 'rfcdiff' in debian/rfcdiff.install
>>
>> The makefile seems to be for internal development use only. Also
>> Fedora is working around that faulty makefile.
> [...]
>> Therefore I would like to keep the current version until upstream
>> comes up with a fixed version, with proper test and install targets
>> (including DESTDIR and PREFIX variables).
>
> yeah, I don't mean you to patch the makefile, please re-read my quote
> above.
> that work in override_dh_auto_install + .install file is duplicated for
> nothing.
> I'm proposing the attached patch, what do you think?
>
I got you wrong there. I removed the lines from d/rules but changed your
patch a little bit for rfcdiff.install.
>> I re-uploaded a modified verion to mentors.
>> Thanks for taking the time.
>
> btw, I'll happily work through git, given that you have a packaging
> repository, and you're using it sanely I'd use it, rather than going
> with tarballs, is way easier for me.
> Just poke when you do changes to review/upload.
>
That is great, it also makes things easier for me.
Thanks again for taking the time.
Greetings
Peter
Reply to: