control: owner -1 !
control: tag -1 moreinfo
On Sun, Dec 20, 2015 at 09:20:57AM +0100, Peter Spiess-Knafl wrote:
> I am looking for a sponsor for my package "rfcdiff".
>
> I want to package abi-monitor and abi-tracker [1], because I think it is
> useful for
> lots of DDs and DMs maintaining shared libraries. abi-tracker has
> rfcdiff as dependency, therefore I need to package it.
>
> Aside that its quite a useful tool to generate html reports of file diff
> s.
wrt generating file diffs, you should have a look at diffoscope :)
> dget -x
> http://mentors.debian.net/debian/pool/main/r/rfcdiff/rfcdiff_1.42-1.dsc
review:
trailing whitespaces:
+ debian/control:15
+ debian/rules:3
there is really no need to do that useless override_dh_auto_install,
just empty that target in d/rules, and write 'rfcdiff' in
debian/rfcdiff.install
Makefile contains an 'include ../Makefile.common', while the file is in
the same directory, guess it needs fixing? once done so the
override_dh_auto_test and override_dh_auto_install can be removed
entirely. This is a problem for upstream, please forward the issue.
stuff check-all-the-things tells me:
$ cme check dpkg
Warning in 'control binary:rfcdiff Depends:2' value 'diffutils': unnecessary unversioned dependency on essential package: diffutils
$ codespell --quiet-level=3
./changelog:178: refering ==> referring
$ licensecheck --check=. --recursive --copyright . | grep -F 'with incorrect FSF address'
./copyright: GPL (v2 or later) (with incorrect FSF address)
please forward the last 2 to upstream.
The rest looks good, if you fix this few bits I'll upload it.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature