Bug#804298: RFS: hello/1.0-1 [ITP] -- homer
Control: owner -1 !
Control: tags -1 moreinfo
Hi,
cd homer-0.26.0~svn3080/
check-all-the-things
codespell --quiet-level=3
(some output)
cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open any of the paths given.'
(some stuff that might be a problem)
# Parsing /proc/cpuinfo is not portable at all, use /sys instead.
$ grep -rF /proc/cpuinfo .
./Homer/bin/analyse-x86.pl: open FLAGS, "grep -Em1 '^flags' /proc/cpuinfo | " or die "could not read cpu flags in $!\n";
./Homer/bin/analyse-x86.pl: open PIPE, "grep -Em1 '^vendor_id.*: ' /proc/cpuinfo | cut -d' ' -f2 | " or die "could not read vendor_id";
duck
E: debian/control: Vcs-Browser: http://anonscm.debian.org/cgit/collab-maint/homer.git/: ERROR (Certainty:certain)
Curl:0 HTTP:404 No error
E: debian/control: Vcs-Git: git://anonscm.debian.org/collab-maint/homer.git: ERROR (Certainty:certain)
fatal: remote error: access denied or repository not exported: /collab-maint/homer.git
pep8 --ignore W191 .
./debian/homer.py:10:80: E501 line too long (140 > 79 characters)
./debian/homer.py:12:1: E302 expected 2 blank lines, found 1
$ find -type f \( -iname '*.pl' -o -iname '*.pm' \) -exec podlint {} \;
Name "Pod::POM::ERROR" used only once: possible typo at /usr/bin/podlint line 19.
$ pyflakes .
./debian/homer.py:7: 'from apport.hookutils import *' used; unable to detect undefined names
$ pyflakes3 .
./debian/homer.py:7: 'from apport.hookutils import *' used; unable to detect undefined names
grep -riE 'fixme|todo|hack|xxx'.
and now a manual review:
1)
lintian overrides:
# see Debian bug #804256
#
postrm-should-call-ldconfig
also the other two lintian overrides, I would prefer lintian complaining rather than overriding because of a lintian bug.
1) package name doesn't match soname, this should be fixed in my opinion
2) using svn for exporting github stuff is... weird?
please consider something like
https://github.com/PRJ/NAME/tarball/master
why not use a watch file and the tarball from upstream?
3) debian/README.Debian, seems useless
4) debian/menu should be removed
https://lists.debian.org/debian-devel-announce/2015/09/msg00000.html
5) d/p/01 config
moving the configuration directory makes it non-trivial to maintain the package and to copy configuration stuff to other distro linux
other stuff seems to be good, but I didn't try to build and run
cheers,
G.
Reply to: