I keep getting 500 from mentors, so would you be so kind to take from /srv/home/users/kaction-guest/public_git/complexity.git? > > I would suggest using https in all the debian/copyright URLs. I fixed, but duck(1) complains about gnutls error. No idea, w3m opens just fine these urls. > > gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -D_FORTIFY_SOURCE=2 -g > - -O2 > -Werror=array-bounds -Werror=clobbered > - -Werror=volatile-register-var > -Werror=implicit-function-declaration > - -fPIE -fstack-protector-strong > -Wformat -Werror=format-security -c > - -o unistd.o unistd.c > > unistd.c:2:0: warning: "_GL_UNISTD_INLINE" redefined #define > > _GL_UNISTD_INLINE _GL_EXTERN_INLINE ^ In file included from > > ../config.h:967:0, from unistd.c:1: ./unistd.h:139:0: note: this is > > the location of the previous > > definition > > # define _GL_UNISTD_INLINE _GL_INLINE ^ Anything with _GL prefix is about gnulib and I would prefer to do not touch it, unless strictly necessery. > > ar: > > > > ar cru libgnu.a fd-hook.o unistd.o xsize.o asnprintf.o > > printf-args.o printf-parse.o vasnprintf.o ar: `u' modifier ignored > > since `D' is the default (see `U') Same. > > $ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not > > find or open any of the paths given.' [src/complexity.c:211]: > > (error) Memory leak: lines_scoring [src/complexity.c:67]: (error) > > va_list 'ap' was opened but not > closed > by va_end(). Fixed. > Let me know how to do you want to proceed with them, and I'll followup > with another review. Yes, please review again. -- Accept: text/plain, text/x-diff Accept-Language: eo,en,ru X-Keep-In-CC: yes X-Web-Site: nanlnhhunqer4xcy.onion
Attachment:
signature.asc
Description: Digital signature