[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#798990: RFS: webdeploy/1.0-1 ITP #798716 -- deploy files via FTP



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Control: owner -1 !
Hi Daniel,

> I'm not sure what's wrong here, the upstream makefile contains this
>  install rule which installs the script and the man page, have I
> done something wrong?: install: all
> 
> install webdeploy $(DESTDIR)$(bindir)
> 
> install -m 0644 webdeploy.1 $(DESTDIR)$(man1dir)
> 
> 

well, it might be good, just I don't like custom makefiles :)

>> 5) install the manpage too.
> (see above)
>> 6) use debian/dirs to create directories, or fix the Makefile :)
> Sorry, once again, complete beginner, what is wrong with the
> makefile here?
>> I'm not sure about perl:Depends, since there is no perl in build
>> dependencies. (also shlibs:depends and so on, because you don't
>> have any shared library)
> I think this was the result of using dh_perl. I expected it to find
> the libterm-readkey-perl Requirement but it didn't, It did however
> add perl as a dependancy. Also, perl is in the build-depends in the
> control file as it contains the pod2man program for generating the
> man page. Is there anything I need to change here? Should I remove
> the shlibs:depends from the control file?

I'm not sure about this but well, seems good!


Last issues:

this is how I would patch the Makefile:
- --- webdeploy-1.0.orig/Makefile
+++ webdeploy-1.0/Makefile
@@ -13,6 +13,7 @@ webdeploy.1: webdeploy
        pod2man --name=WebDeploy -c"WebDeploy - Deploy files via FTP"
- --section=1 --release="Version $(VERSION)" $< > $@

 install: all
+       install -d $(DESTDIR)$(bindir) $(DESTDIR)$(man1dir)
        install webdeploy $(DESTDIR)$(bindir)
        install -m 0644 webdeploy.1 $(DESTDIR)$(man1dir)


removing the debian/webdeploy.dirs
and how I would use the install override:

override_dh_auto_install:
        dh_auto_install -- prefix=/usr


what do you think about?

cheers,

Gianfranco
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWCA+2AAoJEPNPCXROn13ZYYwQAJXA4lKw5y7Wh8IQhCxZStVk
PrsdmTDbFN9sSXd0ddy3QVP75IIiZJl0A9mDE8I4UO7NKV4XXh0baw8dsNfgPg6d
OxODzMaWPGU7s0POrDVD6FoywKYpnLnvGWvXumBLGQNhKDHP+PU923gVgQ7taXyd
EonBLSoorD9iLnR1yH+oNennAaCA2TkQkmMRUrWXbbAZN9cZWYH07k26/qZ8uehA
0adUM67HVaGgCvd4CJ7zYT40h/AqzdnPi9Th1rjfwaEEPOWGARKfpoALN/XeB6OH
pazQUmV6MAzTA26kGWAKbZwpwB5t/VsRfF0M+uk3rCucJNedLwp1fj3HT8LIJOyK
QQr7NGtWVmt07lZjEBHj0j8hbCOkBCf9/O3DZjABrQKUr/I6bHLOPrVueQdDThpq
s5aPLhx9gwj+gEsyP+zSYCZNMWvRqcI/itMlM5mDOOe9y5zMOtlSeUyQ2GvSBCyV
ED4QUXSAwPLlYCF0FNG7xNDovVXgYwX73xkn8EgjzAjtBx181dg3Zq8YZboss75b
I+P0kCXeE0e5edufRM7IGLV1a+q4ON7K9yv1N0mpwtCcAPtxjEFw6l0KCdU0hOmb
ye5ATyuaut8c0D/mXCXHVDERq+jJc0RMprXz5owg8r+n/gBGlg9Lz6ThKVf745cD
yLMKglEmjkXvIfUQgEPo
=i5qg
-----END PGP SIGNATURE-----


Reply to: