Bug#798990: RFS: webdeploy/1.0-1 ITP #798716 -- deploy files via FTP

[Daniel Bailey <d@nielbailey.com>]

Thanks for the response, I've fixed some things and was confused by some other things, see inline texts.

On 15/09/15 12:06, Gianfranco Costamagna wrote:

Hi Daniel,




(please upload on mentors.debian.net next time)

I was getting some SSL error on mentors.debian.net, I have since got this done. It is now here:
https://mentors.debian.net/package/webdeploy

1) changelog: you need to open an ITP bug and set the target distribution to unstable.

I've added the "closes ITP bug" info to the changelog

2) control: std-version should be 3.9.6

Done

3) copyright should be in dep5 format
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
and include the license.

Done

4) rules: please use a debian/install file for installing the binary
and build documentation at runtime
(or fix the upstream Makefile)

I'm not sure what's wrong here, the upstream makefile contains this install rule which installs the script and the man page, have I done something wrong?:

install: all
	install webdeploy $(DESTDIR)$(bindir)
	install -m 0644 webdeploy.1 $(DESTDIR)$(man1dir)

5) install the manpage too.

(see above)

6) use debian/dirs to create directories, or fix the Makefile :)

Sorry, once again, complete beginner, what is wrong with the makefile here?

I'm not sure about perl:Depends, since there is no perl in build dependencies.
(also shlibs:depends and so on, because you don't have any shared library)

I think this was the result of using dh_perl. I expected it to find the libterm-readkey-perl Requirement but it didn't, It did however add perl as a dependancy.
Also, perl is in the build-depends in the control file as it contains the pod2man program for generating the man page. Is there anything I need to change here?
Should I remove the shlibs:depends from the control file?

Thanks.
Dan.

cheers,

Gianfranco