Bug#799094: RFS: node-kerberos/0.0.14-1 [ITP]

[Christopher Hoskin <christopher.hoskin@gmail.com>]

Dear Gianfranco,

Thank you for the review. I have increased dh compat to 9 and refactored the patches.

I have reviewed all of the other _javascript_ packages I am aware of which use GYP (node-contextify, node-groove,  node-leveldown,  node-postgres, node-sqlite3,  node-stringprep,  node-ws, node-zlib, node-expat, node-iconv, node-mapnik, node-raptor, node-srs and node-zipfile) and they all seem to work in this way, with the exception of node-ws, in which case upstream includes a Makefile which includes similar commands. Debhelper doesn't currently have a "--with gyp" option as far as I know, so I can't see how this can be simplified? Please can you make some suggestions?

I forgot to mention that I have also put the code in git.debian.org/git/pkg-_javascript_/node-kerberos.git .

Thanks again.

Christopher

On 18 September 2015 at 09:25, Gianfranco Costamagna <costamagnagianfranco@yahoo.it> wrote:

Control: owner -1 !

Hi:

control/compat: debhelper and compat: please set to 9

control: priority: optional
patches: debian.patch is not a good patch name, maybe "change-path or similar might be"

(the patch might be even split in two, since it does two different things)

rules: I see some (maybe) useless complications.

are you sure you cant build it with some standard dh calls like e.g. package
node-typedarray

(yes, you build a library, so some stuff might be needed)


the other stuff seems good.



cheers,

G.