Bug#799205: RFS: eviacam/2.0.1-5 [ITP] -- webcam based mouse emulator
Hi Gianfranco and Alex,
Thanks for your reviews. Hopefully, I've addressed most of the issues.
lets review:
d/changelog: please remove the space before ")"
d/rules: usually it is better to use dh-autoreconf instead of autotools-dev, because the first is a superset
(this means a change on control file too, and the drop of autotools-dev)
d/control: please run "wrap-and-sort" command, to sort dependencies
Done. dh-autoreconf worked without issues.
"Recommends: wx2.8-i18n" what?
It contains localization strings for the wx library. Should be required package, perhaps?
the whole wx2.8 is not in testing, please use wx3.0, otherwise your package won't be included in Stretch.
Updated dependencies to wx3.0 (was already working with this library)
d/copyright: missing sone GPL2 licenses
I removed some unneeded files from the orig.tar.gz and I added missing GPL2 licenses
the other stuff might be food
maybe run "debconf-updatepo" in the clean target, to avoid forgetting of updating translations.
I use to run 'make deb-src' to generate the source package which already update translations.
I might take a look.
I grape the source from <http://mentors.debian.net/package/eviacam>. I
think I find a problem with the build dependencies, the build
dependencies contain `libopencv-dev | libcv-dev'. I first choose to
install `libcv-dev', but I get a build failure. After that, I choose
to install `libopencv-dev' instead and everything works fine. So in
short, I think `libopencv-dev | libcv-dev' should be changed to
`libopencv-dev' in `debian/control' file.
Message to Cesar: I have just found out you are the upstream
developer, your program looks interesting to me!
Message to Gianfranco: Could be reproduce this? I am running Sid. I
remember Cesar mentioning he is running Jessie.
true story.
Perhaps you should add the directory containing `opencv.pc'
to the PKG_CONFIG_PATH environment variable
No package 'opencv' found
not found
configure: error: opencv is required.
apt-file search opencv.pc
libopencv-dev: /usr/lib/x86_64-linux-gnu/pkgconfig/opencv.pc
so maybe the second dependency (alternative) is simply wrong as you said :)
I guess the 2nd dependency was wrong.
libopencv-dev depends on libcv-dev, so is enough with the first. I also removed other unneeded dependencies.
Updated package available at mentors.
Changes tracked at debian-review branch:
https://github.com/cmauri/eviacam/commits/debian-review
Regards
Cesar
Reply to: