Bug#798044: RFS: php-mf2/0.2.12-1 [ITP] -- Microformats2 is the simplest way to markup structured information in HTML.

[Gianfranco Costamagna <costamagnagianfranco@yahoo.it>]

Hi Bhuvan

the packaging looks good to me, however I have some issues that you might want to address:

1) 
override_dh_install:
dh_install


well, this is funny and useless :)

2) no watch file is usually bad...
please add one if possible

3) DH_VERBOSE in the rules file might be disabled, not an issue, just be sure that you want verbose
log by default.

4) debian/install.

well, upstream might want to have a custom Makefile for installing stuff

5) copyright: 

License: AGPL-3+
Released under the GNU Affero General Public License, version 3 or later.
See https://www.gnu.org/licenses/agpl.html for terms.


I usually prefer the same license as upstream, this way you avoid license incompatibilities
in patch forwarding upstream and you make easier to keep the copyright updated.

moreover the license text should be extended
http://sources.debian.net/src/ghostscript/9.16%7Edfsg-2/debian/copyright/?hl=59#L387

6) lintian complains from mentors

I composer-package-without-pkg-php-tools-builddep 
I description-synopsis-might-not-be-phrased-properly 


7) (something strictly personal)
usr/share/php/Mf2

I personally do not like Upper Case in Linux, but this is just me, and you shouldn't diverge
on path from upstream.

However please consider making it lower case.


(note: I have little php knowledge, so I'm not sure I'll be able to sponsor the package, sorry)

cheers,

G.




Il Venerdì 4 Settembre 2015 21:03, Bhuvan Krishna <bhuvan@swecha.net> ha scritto:
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

  I am looking for a sponsor for my package "php-mf2":

* Package name    : php-mf2
   Version         : 0.2.12
Upstream Author : Barnaby Walters <barnaby@waterpigs.co.uk>
* URL             : http://microformats.org/wiki/microformats-2
* License         : MIT
  Programming Lang: PHP


  It installs files to /usr/share/php/Mf2

  To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/php-mf2


  Alternatively, one can download the package with dget using this command:

  dget -x
http://mentors.debian.net/debian/pool/main/p/php-mf2/php-mf2_0.2.12-1.dsc

  More information about hello can be obtained from
http://microformats.org/wiki/microformats-2#PHP.

  Regards,
Bhuvan Krishna