Hi Gianfranco, >> This was all done by upstream's packaging, which I used as a base. >> Credits to Peter Levi :) > > I don't see it > http://bazaar.launchpad.net/~peterlevi/variety/trunk/view/head:/setup.py > > am I looking in the correct place? > > > I'm talking about this > https://packaging.python.org/en/latest/requirements.html Uhhh, I don't see it either. Upstream uses distutils, and I've never changed the setup.py myself when I packaged it. >>> 4) rules: I think the uscan get-orig-source can be dropped, but I didn't try>get-orig-source is entirely an optional target, but it makes fetching >> the source tarball easier if you only have the debian/ tree handy. Other >> sponsors have asked for it before. >> https://wiki.debian.org/onlyjob/get-orig-source > > well, usually it is used when a repack/dfsg is needed, otherwise I see no point > of calling uscan in a target, but well, you can leave it, > just please note that > "uscan" should work alone. > > (otherwise please patch the watch file to call get-orig-source) > Noted. uscan is called with a bunch of arguments in get-orig-source to comply with policy, so I assume they do something different than plain "uscan" on the command line. >> 5) copyright: please provide something more than a symlink for the GPL-3 license > I think you might want to avoid the X-Comment (I don't know what does it mean) > > e.g. (taken from codesearch.d.n) > > http://sources.debian.net/src/mussort/0.3-5/debian/copyright/?hl=7#L7 > Done. >> This is used for the "Add Panoramio" feature in Variety (In the General >> tab of Variety Preferences - Images section - Add - Panoramio). When >> chosen, it opens up a window with a Google Maps overlay allowing you to >> pick a location to get Panoramio images from. Because this is only >> loaded upon request, I'm not sure it's really a privacy breach. Removing >> it would mean loss of functionality or, at the very least, having to use >> a less friendly way of looking up locations. >> Panoramio is a location-based photo sharing service operated by Google: >> https://en.wikipedia.org/wiki/Panoramio >> >> Best, >> James > > actually I know what Panoramio is, the problem is that it is nice when external requests > are avoided. In that case I guess we can leave with the potential privacy issue > (we already have ~40k packages with that lintian tag). > > I guess people who want to avoid potential security threats needs to disable js anyway, > without relying too much on the Debian archive to avoid such calls to e.g.: > > https://maps.googleapis.com/maps/api/js?v=3.exp&libraries=panoramio Ack. > so if you can fix the last two or three nitpicks I'll be happy to followup with some package testing. > > e.g. in a clean environment I get the following errors (during build): > > ERROR: Python module bs4 not found > ERROR: Python module helpers not found > ERROR: Python module bs4 not found > ERROR: Python module pyexiv2 not found > ERROR: Python module DominantColors not found > ERROR: Python module configobj not found > ERROR: Python module configobj not found > ERROR: Python module helpers not found > ERROR: Python module varietyconfig not found > ERROR: Python module lxml not found > ERROR: Python module PIL not found > ERROR: Python module helpers not found > ERROR: Python module dbus not found > ERROR: Python module dbus.service not found > ERROR: Python module dbus.glib not found > ERROR: Python module cairo not found > ERROR: Python module PIL not found > ERROR: Python module Util not found > ERROR: Python module DominantColors not found > ERROR: Python module PIL not found > ERROR: Python module varietyconfig not found > ERROR: Python module Builder not found > ERROR: Python module pycurl not found > ERROR: Python module configobj not found > ERROR: Python module IVarietyPlugin not found > ERROR: Python module PIL not found > > > > This is I guess what I said before, add them to build dependencies, and to install_requires, and > > let python:Depends add them to the runtime package automatically. To be honest, I haven't got a clue what these errors are about. setup.py is building something and trying to find dependencies, I guess. I've added a bunch of build-deps which suppress the "Python module not found" errors for external libraries (bs4, dbus, etc.), but the internal Variety libraries (varietyconfig, IVarietyPlugin, etc.) still raise errors. None of it is fatal though, and I can still build it with pbuilder and such. Related: https://answers.launchpad.net/variety/+question/213828 I haven't patched the setup.py file yet, since install_requires needs setuptools instead of distutils as far as I can tell. Is switching to setuptools for this a good idea? Best, James
Attachment:
signature.asc
Description: OpenPGP digital signature