Bug#797636: RFS: variety/0.5.4-1 [ITP]

[Gianfranco Costamagna <costamagnagianfranco@yahoo.it>]

Control: owner -1 !

Control: tags -1 moreinfo




Hi,

1) please remove everything from changelog.

usually it is better to keep just an "initial ... Closes: #XXX" entry

2)  Bonus points for using pybuild instead of distutils-extra :)

3) Bonus points for using install_requires: in setup.py instead of hardcoding all the
dependencies in control file Runtime Depends (letting python:Depends do its job)


4) rules: I think the uscan get-orig-source can be dropped, but I didn't try


5) copyright: please provide something more than a symlink for the GPL-3 license


6) I desktop-entry-lacks-keywords-entry
usr/share/applications/variety.desktop


please fix if possible

7) X privacy-breach-generic

usr/share/variety/panoramio/panoramio.html (https://maps.googleapis.com/maps/api/js?v=3.exp&libraries=panoramio,places)


same here

cheers,

Gianfranco