Bug#788583: RFS: blktool -- tune low-level block device parameters [ITA]
On Sat, Jul 04, 2015 at 03:12:21PM -0700, Vincent Cheng wrote:
> Why is this upload targeting experimental instead of unstable?
>
> Just a few comments after having reviewed your package (none of these
> are strictly blockers, however):
> - Drop quilt from build-depends; unneeded because you're using source
> format "3.0 (quilt)" (and so dpkg-source handles everything for you),
> and also drop debian/README.source (which is more applicable if you're
> using quilt without source format 3.0 quilt) and drop
> patchsys-quilt.mk from d/rules.
> - Please either push your changes to collab-maint, or drop the
> Vcs-{Git,Browser} fields in d/control.
Hi Vincent,
Thanks for comments, I'm going to fix them all.
As for collab-maint, I've just send a request to join to the project via
[1], could you send email with acknowledge by request?
Thanks,
Azat.
[1] https://alioth.debian.org/projects/collab-maint/
> - Consider adding patch headers to the other two existing patches
> you've applied to this package; I suggest DEP-3 formatted headers [1],
> but git format-patch style headers are fine too.
> - d/copyright references a versionless symlink to the GPL; please
> change it to /usr/share/common-licenses/GPL-2. While you're at it, you
> may consider updating d/copyright to follow DEP-5 conventions [2].
>
> [1] http://dep.debian.net/deps/dep3/
> [2] https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Reply to: