Bug#788583: RFS: blktool -- tune low-level block device parameters [ITA]
Control: tag -1 + moreinfo
Control: owner -1 !
Hi Azat,
On Fri, Jun 12, 2015 at 3:36 PM, Azat Khuzhin <a3at.mail@gmail.com> wrote:
> Package: sponsorship-requests
> Severity: normal
>
> Dear mentors,
>
> I am looking for a sponsor for my package "blktool"
>
> Package name : blktool
> Version : 4-7
> Upstream Author : Jeff Garzik <jgarzik@pobox.com>
> URL : http://sourceforge.net/projects/gkernel/files/blktool/
> License : GPL v2
> Section : admin
>
> It builds those binary packages:
>
> blktool - tune low-level block device parameters
>
> To access further information about this package, please visit the following URL:
>
> http://mentors.debian.net/package/blktool
>
>
> Alternatively, one can download the package with dget using this command:
>
> dget -x http://mentors.debian.net/debian/pool/main/b/blktool/blktool_4-7.dsc
>
> Changes since the last upload:
>
> * QA upload
> * New maintainer. (Closes: #695127).
> * Fix "blktool readonly is broken" (Closes: #641164).
> * bump debhelper version to 9
> * fix changelog-should-mention-qa
> * fix ancient-standards-version 3.7.2.2 (current is 3.9.6)
> * fix vcs-field-not-canonical
> * fix xs-vcs-header-in-debian-control
> * add homepage
>
Why is this upload targeting experimental instead of unstable?
Just a few comments after having reviewed your package (none of these
are strictly blockers, however):
- Drop quilt from build-depends; unneeded because you're using source
format "3.0 (quilt)" (and so dpkg-source handles everything for you),
and also drop debian/README.source (which is more applicable if you're
using quilt without source format 3.0 quilt) and drop
patchsys-quilt.mk from d/rules.
- Please either push your changes to collab-maint, or drop the
Vcs-{Git,Browser} fields in d/control.
- Consider adding patch headers to the other two existing patches
you've applied to this package; I suggest DEP-3 formatted headers [1],
but git format-patch style headers are fine too.
- d/copyright references a versionless symlink to the GPL; please
change it to /usr/share/common-licenses/GPL-2. While you're at it, you
may consider updating d/copyright to follow DEP-5 conventions [2].
Regards,
Vincent
[1] http://dep.debian.net/deps/dep3/
[2] https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Reply to: