Bug#788217: RFS: clfft/2.4-1 [ITP Bug#783084] -- OpenCL FFT library

[Ghislain Vaillant <ghisvail@gmail.com>]

On Thu, 18 Jun, 2015 at 1:15 PM, PICCA Frederic-Emmanuel <frederic-emmanuel.picca@synchrotron-soleil.fr> wrote:

Hello, upload but I have a few remarks. here the rules file

# see EXAMPLES in dpkg-buildflags(1) and read /usr/share/dpkg/* DPKG_EXPORT_BUILDFLAGS = 1 include /usr/share/dpkg/default.mk

why is it necessary to export the symbols since you are using compat level 9 ?

Blind copy from the multiarch page of the Debian wiki. Will remove it in a later update.

Then, I am guessing the explicit dependency on dpkg-dev is not needed either ?

%: dh $@ --sourcedirectory=src \ --buildsystem=cmake \ --parallel \ --dbg-package=libclblas2-dbg

override_dh_auto_configure: dh_auto_configure -- \ -DBUILD_RUNTIME=ON \ -DBUILD_TEST=OFF \ -DBUILD_PERFORMANCE=OFF \ -DBUILD_SAMPLE=OFF \ -DBUILD_CLIENT=ON \ -DBUILD_KTEST=OFF \ -DBUILD_SHARED_LIBS=ON echo "I: Generating Doxygen documentation" cd doc/ && doxygen clBLAS.doxy && rm html/jquery.js

why do you build the documentation during the configuration why not puting the documentation generation under an: override_dh_auto_build ?

Because it worked and I did not look further than that ^^.

Would be cleaner in a override_dh_auto_build, I agree. Added to my todo-list.

override_dh_auto_clean: dh_auto_clean [ ! -f doc/doxygen_sqlite3.db ] || $(RM) doc/doxygen_sqlite3.db [ ! -d doc/html ] || $(RM) -rf doc/html

why no -$(RM) -f doc/doxygen_sqlite3.db -$(RM) -rf doc/html

Force remove versus remove if present philosophy. That being said, just realized I do a force 

remove on doc/html anyway...

To be changed as well.

Cheers Fred

Would you consider sponsoring clBLAS and ArrayFire as well? :-)

Thanks for the comments and mentorship on clFFT, very much appreciated!

Ghis