Bug#765648: RFS: fbxkb/0.6-1.3 [NMU]
Hi Dimitry,
Am Sonntag, den 02.11.2014, 21:56 +0200 schrieb Dmitry Borisyuk:
> Dear mentors,
>
> I've recently uploaded a new version of fbxkb to mentors,
> with even more lintian warnings fixed.
> Please, take a look at it, and sponsor the upload if you find it useful.
>
>
> To access further information about this package, please visit the following URL:
>
> http://mentors.debian.net/package/fbxkb
>
> Alternatively, one can download the package with dget using this command:
>
> dget -x http://mentors.debian.net/debian/pool/main/f/fbxkb/fbxkb_0.6-1.3.dsc
>
> Changelog:
>
> * Non-maintainer upload.
> * Fix parsing of keyboard info, to show proper "us" flag. (Closes: #412254)
> * Use g_strdup() before passing strings to g_hash_table_insert(),
> to avoid use-after-free.
> * Remove deprecated gtk_set_locale() and change deprecated gdk_window_lookup()
> to gdk_x11_window_lookup_for_display().
> This fixes "pointer-trouble-at-implicit" lintian error.
> * Don't unconditionally strip fbxkb binary (Closes: #436824)
> * Fixed all lintian warnings.
> * Removed extraneous dependencies.
> * Added homepage and debian/watch.
>
>
> Regards,
> Dmitry Borisyuk
>
>
Thanks for taking a look a the package and working on it to fix some
long outstanding bugs and overall improving the package state.
From here, it looks if the package's maintainer, Vadim Vatlin is
inactive. As this was his only upload ever, and as the domain of his
email returns NXDOMAIN, I orphaned it right now, and if you want, it can
be adopted by you.
If you want to be the new maintainer, please see
http://www.debian.org/devel/wnpp/index.html#howto-o for detailed
instructions how to adopt a package properly.
This package is probably a good exercise package to learn the packaging
skills. I recommend reading the refrences in section 3 of
http://mentors.debian.net/intro-maintainers.
For the package, there are several things to be fixed before it can be
uploaded:
-> The package should be converted to debian/source/format "3.0
(quilt)". This requires that only files in the debian directory can be
altered, and if you need to change files outside of this, you need to do
this with patches. The tool quilt(1) will help you here.
Links to support you: https://wiki.debian.org/Projects/DebSrc3.0 ,
especially the 3 links in the section "But, how do I actually work with
the 3.0 (quilt) format?" will give you hints how to work with quilt.
Basically, you need to restore the original upstream tarball and then
apply the modifications as patches.
The patches itself should be based on a "one-fix-one-patch" rule,
and dep3-header added (quilt header -e --dep3 will give you an template)
-> d/copyright should be updated for the machine readable version. Refer
to
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
-> d/changelog Please note that you skipped Debian version -1.2;
however, as the package is now orphaned, its needs to be different now:
The version will be "-2" and the first line needs to be either
"New maintainer (Closes: #767970)" (if you adopt) or "QA Upload." (if you don't)
-> d/rules should be converted to short debhelper(7) format.
Read also dh(1).
(you will need to override dh_auto_configure as the configure script is not a autconf one.)
-> Standard-Version has been bumped to 3.9.6, which is right. However,
you need to document that in the changlog. Did you check the complete
upgrade checklist?
https://www.debian.org/doc/packaging-manuals/upgrading-checklist.txt
So many thanks again; let me know if you need any hints and ping me when you implemented the above.
--
tobi
Reply to: