On Wed, Sep 24, 2014 at 03:07:29PM +0200, Jakub Wilk wrote: > * Peter Pentchev <roam@ringlet.net>, 2014-09-24, 14:50: > >I've uploaded a new version to the same mentors.d.n location. > > ... which is: > https://mentors.debian.net/debian/pool/main/h/hexer/hexer_0.1.8-1.dsc > > You removed debian/dirs and debian/docs, but that doesn't seem to be > documented in the changelog. Yep. The debian/docs one was kind of implied in the "do not install the useless README file", but you're right, I made it more explicit. The debian/dirs one missing was a result of my omission in the development process - I created a patch, noted it in the changelog, noted that it replaced debian/dirs, then I released a new upstream version and removed the changelog entry about the patch whatsoever, taking the debian/dirs note along with it. > The default pager should be "pager", not "more" (see Policy §11.4). Right, thanks. These two issues are fixed in the new version uploaded to the same mentors.d.n location: dget -x https://mentors.debian.net/debian/pool/main/h/hexer/hexer_0.1.8-1.dsc > The following problems don't necessarily have to be fixed in this upload; > please use your own discretion: > > Here[0], hexer doesn't restore background color on exit. I don't like my > shell prompt in blue! :-( Hm. This is an interesting one, I'll have to research it a bit more. The funny part? I can reproduce it - when I run hexer with TERM=linux from a Bash shell! If I run it from Zsh, there's no problem. I will definitely look into it, maybe take a look at a couple of other programs that use libtinfo; to be honest, ISTR Bash having a problem with recovering from "man" on some other Linux distributions a couple of years ago, I wonder if it could be related. Here's hoping this doesn't turn out to be another security bug in Bash :P (or, for that matter, in hexer :) > Lintian says: > X: hexer: binary-file-built-without-LFS-support usr/bin/hexer > > And indeed, I can't open files bigger than 2G. Pfth, right. Lintian grew this warning after the last upload of hexer some years ago, and I switched from i386 to x86_64 a couple of months ago, so I missed it. Thanks, and here goes another sbuild chroot for mandatory testing before uploading :) > But on a second thought, > hexer seems to load whole file into memory, so maybe it's good it didn't > attempt to load anything that big. ;-> Yep, that's true :) One of my long-term wishes about hexer is to find the time to dive into the code and figure out if there's a way to do most of its work in some kind of window over the file. Of course, search operations will pose a problem, and so will some even simpler operations like inserting bytes :) > codespell(1) finds a bunch of typos: [snip] > spellintian[1] finds a few more: [snip] Oof, yes, thanks. I'll take care of these in the next upstream release. Thanks a lot for your work on reviewing this! G'luck, Peter -- Peter Pentchev roam@ringlet.net roam@FreeBSD.org p.penchev@storpool.com PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13
Attachment:
signature.asc
Description: Digital signature