Hello Stephen,
Am Sonntag, den 14.09.2014, 16:17 +0200 schrieb Stephen Kitt:
> Hi Jörg,
>
> On Sun, 14 Sep 2014 14:29:18 +0200, Jörg Frings-Fürst
> <debian@jff-webhosting.net> wrote:
> > Am Sonntag, den 14.09.2014, 12:35 +0200 schrieb Stephen Kitt:
> > Line in d/changelog and comments in d/rules removed.
> > I think that hardening=+all is not necessary for argyll.
>
> OK.
>
> > [...]
> > > > * debian/patches/
> > > > - New 110_dispwin_segfault.patch to prevent segfault by
> > > > wrong parameter (Closes: #700253)
> > >
> > > I see other patches as well... 15_jam.patch.org should be removed, along
> > > with the various patches which are no longer used in the series file (and
> > > you should clean up the series file too). In 110_dispwin_segfault.patch,
> > > is there a link to the mailing list archives you could copy in the
> > > "Forwarded" item?
> >
> > Link is included. Useless patches deleted and from d/p/series removed.
>
> I see a link in 15_jam.patch, but not in 110_dispwin_segfault.patch.
>
Sorry, its my mistake.
> Lintian doesn't reveal anything nasty about the package; there are a few
> pre-built Windows binaries, but the source is also included so there's no
> need to repack the source. The warning about the short license names is a
> false-positive which is fixed in lintian 2.5.27.
>
The three Windows binaries would be removed in the next upstream
release. Therefore I don't create a dsfg source without them. I hope
thats ok.
> Upgrading argyll does reveal a real problem though... Given that you're
> shipping all the documentation in argyll-doc, and symlinking from the other
> two packages, you need to replace the old directories with symlinks, using
> something like this in argyll's postinst:
>
> # Replace documentation directory with symlink
> if [ -d /usr/share/doc/argyll ] && [ ! -L /usr/share/doc/argyll ]; then
> if rmdir /usr/share/doc/argyll 2>/dev/null; then
> ln -sf argyll-doc /usr/share/doc/argyll
> fi
> fi
>
> Otherwise /usr/share/doc/argyll ends up being an empty directory.
>
I have added them in section configure in (argyll|argyll-dbg|
icc-utils).postinst.
If the directory cannot be removed I move it to *.bak and set the
symlink then.
> Incidentally, doing this means that argyll depends on argyll-doc; was that
> intentional?
Yes. I have added the depend.
Uploaded to mentors[1] again.
>
> Regards,
>
> Stephen
CU
Jörg
[1] http://mentors.debian.net/package/argyll
--
pgp Fingerprint: 7D13 3C60 0A10 DBE1 51F8 EBCB 422B 44B0 BE58 1B6E
pgp Key: BE581B6E
CAcert Key S/N: 0E:D4:56
Jörg Frings-Fürst
D-54526 Niederkail
Threema: SYR8SJXB
IRC: j_f-f@freenode.net
j_f-f@oftc.net
Attachment:
signature.asc
Description: This is a digitally signed message part