Bug#758056: RFS: binwalk/2.0.1-1
Hi Vincent,
> Il Martedì 19 Agosto 2014 11:09, Vincent Cheng <vcheng@debian.org> ha scritto:
> > Control: tag -1 + moreinfo
>
> On Wed, Aug 13, 2014 at 12:49 PM, Gianfranco Costamagna
> <costamagnagianfranco@yahoo.it> wrote:
>> Package: sponsorship-requests
>> Severity: normal
>>
>>
>> Dear mentors,
>>
>> I am looking for a sponsor for my package "binwalk"
>>
>> * Package name : binwalk
>> Version : 2.0.1-1
>> Upstream Author : Craig Heffner <heffnercj@gmail.com>
>> * URL : https://github.com/devttys0/binwalk
>> * License : Expat/Zlib
>> Section : devel
>>
>> It builds those binary packages:
>>
>> binwalk - tool for searching binary images for embedded files and
> executables
>>
>> To access further information about this package, please visit the
> following URL:
>>
>> http://mentors.debian.net/package/binwalk
>>
>> Alternatively, one can download the package with dget using this command:
>>
>> dget -x
> http://mentors.debian.net/debian/pool/main/b/binwalk/binwalk_2.0.1-1.dsc
>>
>> Changes since the last upload:
>>
>> * Imported Upstream version 2.0.1 (Closes: #727553)
>> - Updated docs location
>> * d/r: Removing binary files when cleaning
>> * d/c: X-Python-Version: >= 2.7
>> * d/p/destdir.patch: Override install path
>> * Add some b-d and d
>> * Bump std-version to 3.9.5, no changes required
>> * Add myself to uploaders.
>> * d/{control,watch,copyright} New website (Closes: #734708)
>> * Canonical VCS urls.
>> * Update man page.
>
> This isn't a thorough review, but anyways...
>
> debian/copyright is incomplete, missing:
> - copyright/licenses of bundled file, pyqtgraph, ssdeep (tarballs in
> src/bundles/)
I actually don't use them, but I added them instead of removing the tarballs, since one day it might be necessary to use one of them (in case of incompatibilities between particular library versions), and will be easier to enable them at runtime.
I usually leave the removal only for non dfsg stuff.
> - src/C/compress/compress42.c
> - src/C/miniz/tinfl.c
>
Done
> You may want to trim down your newly added dependencies, and add only
> the dependencies that you actually need, e.g. tar and gzip are both
> Essential: yes,
Removed, wonderful!
> and do you really need to depend on a JDK?
grep jar . -R
./src/binwalk/config/extract.conf:^zip archive data:zip:jar xf '%e' # jar does a better job of unzipping than unzip does...
it seems really needed, this program does a great job in its goal, and jar is quite essential for doing it :(
I tried to ask upstream about dependencies, I also opened an upstream issue [1], and seems that (also by looking at the code) they are all needed.
[1] https://github.com/devttys0/binwalk/issues/62
Have many thanks for reviewing it, the new package is uploaded on mentors!
Gianfranco
>
>
> Regards,
> Vincent
>
Reply to: