[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#758056: RFS: binwalk/2.0.1-1



Control: tag -1 + moreinfo

On Wed, Aug 13, 2014 at 12:49 PM, Gianfranco Costamagna
<costamagnagianfranco@yahoo.it> wrote:
> Package: sponsorship-requests
> Severity: normal
>
>
>   Dear mentors,
>
>   I am looking for a sponsor for my package "binwalk"
>
>  * Package name    : binwalk
>    Version         : 2.0.1-1
>    Upstream Author : Craig Heffner <heffnercj@gmail.com>
>  * URL             : https://github.com/devttys0/binwalk
>  * License         : Expat/Zlib
>    Section         : devel
>
>   It builds those binary packages:
>
>     binwalk    - tool for searching binary images for embedded files and executables
>
>   To access further information about this package, please visit the following URL:
>
>   http://mentors.debian.net/package/binwalk
>
>   Alternatively, one can download the package with dget using this command:
>
>     dget -x http://mentors.debian.net/debian/pool/main/b/binwalk/binwalk_2.0.1-1.dsc
>
>   Changes since the last upload:
>
>   * Imported Upstream version 2.0.1 (Closes: #727553)
>     - Updated docs location
>   * d/r: Removing binary files when cleaning
>   * d/c: X-Python-Version: >= 2.7
>   * d/p/destdir.patch: Override install path
>   * Add some b-d and d
>   * Bump std-version to 3.9.5, no changes required
>   * Add myself to uploaders.
>   * d/{control,watch,copyright} New website (Closes: #734708)
>   * Canonical VCS urls.
>   * Update man page.

This isn't a thorough review, but anyways...

debian/copyright is incomplete, missing:
 - copyright/licenses of bundled file, pyqtgraph, ssdeep (tarballs in
src/bundles/)
 - src/C/compress/compress42.c
 - src/C/miniz/tinfl.c

You may want to trim down your newly added dependencies, and add only
the dependencies that you actually need, e.g. tar and gzip are both
Essential: yes, and do you really need to depend on a JDK?

Regards,
Vincent


Reply to: