[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#742077: RFS: vcmi/0.95-1 [ITP]



2014-08-18 12:47 GMT-03:00 Johannes Schauer <j.schauer@email.de>:
> Hi Eriberto,


Hi Johannes. Thanks for your reply.


> Quoting Eriberto (2014-08-18 16:55:20)
>> I saw your package in mentors.debian.org and it has several Lintian messages.
>>
>> IMHO, to get a sponsor you must, at least, clear your package removing
>> all possible messages.
>
> which Lintian messages are you referring to?
>
> There is one pedantic warning 'debian-watch-may-check-gpg-signature' which I
> cannot fulfill because upstream does not use gpg.


Yeap. So, I wrote 'removing all possible messages'  because I thought about it.


> There is 'binary-without-manpage' which I could fulfill but that would be a
> very empty man page because the game does not have any commandline options.


I understand your POV. However, from Debian Policy[1]:

"Each program, utility, and function should have an associated manual
page included in the same package. It is suggested that all
configuration files also have a manual page included as well. Manual
pages for protocols and other auxiliary things are optional.

If no manual page is available, this is considered as a bug and should
be reported to the Debian Bug Tracking System (the maintainer of the
package is allowed to write this bug report themselves, if they so
desire). Do not close the bug report until a proper man page is
available."

I have some very long manpages and short manpages too. When an user
see a command but he don't know what is this, he always tries '$man
command' to get an explanation.

[1] https://www.debian.org/doc/debian-policy/ch-docs.html


> There is 'hardening-no-fortify-functions' which is a false positive.

Ok, the same case of the GPG signature.

> And there is 'spelling-error-in-binary' which is a false positive as well.

It is a classical Lintian override case.

In your package, please:

1. I suggest you add a d/README.source explaining why it is DFSG and
telling which files have been removed. I saw it in d/copyright but I
suggest a detailed README too.

2. d/copyright: I suggest put the range of years to 'Files: *'. Can be
a unique range for all authors (2007-2014). I think that there are
files with copyright not listed at d/copyright. I found
lib/minizip/mztools.h. You can use 'grep -sri copyright *' to see all
files.

3. d/docs: the README.linux is useless because a Debian final user
doesn't compile codes. Please, remove it.

4. A doubt: why you didn't make a separated package for shared libraries?

5. You need lintian overrides to 'I: vcmi: spelling-error-in-binary
usr/games/vcmilauncher tEH the' and to 'I: vcmi:
spelling-error-in-binary usr/lib/x86_64-linux-gnu/vcmi/libvcmi.so tEH
the'.

6. Please, add a simple manpage to usr/games/vcmilauncher and
usr/games/vcmiserver.

Thanks a lot for your work.

Regards,

Eriberto


Reply to: