[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#749575: RFS: neopi/0.0+git20120821-1 [ITP]



On 17 August 2014 19:20, Eriberto Mota <eriberto@debian.org> wrote:
>
> 1. Change the tarball name to neopi-0.0+git20120821.9ffff8. I am
> asking for it because we can have several commits in a same day.
>

Done.

> 2. d/compat: change to 9.

Done.

>
> 3. d/control: change Section to web and Priority to optional. Remove
> ${shlibs:Depends}.

Done.

>
> 4. d/copyright: the upstream copyright years must be 2010-2012 and the
> license is clearly GPL-3+.
>

Done.

> 5. d/neopi.1: remove the GFDL comment. Please, see it:
> https://www.debian.org/vote/2006/vote_001. Note that if you use an
> extra license you must add this license in d/copyright.

Done.

>
> 6. d/rules: I suggest you use a file d/install instead the
> override_dh_install. But you can keep it.

Keeping it. Using the override eases renaming the file.

>
> 7. d/watch: not working. Is it a preparation to future?
>

Yes. Upstream doesn't do any release by tarball or git tags ATM.

> 8. The upstream says in README.md: "animal_shell_encoder.php and
> animal_shell_poc.php are two Proof-of-Concept-type examples
> scripts...". So, please, using d/examples, add these files to your
> package. The users will read the upstream README and search for these
> files.
>

Done.

I've uploaded a new version to mentors.d.n [1].

Thanks for your time and review. Regards.

[1] http://mentors.debian.net/debian/pool/main/n/neopi/neopi_0.0+git20120821.9ffff8-1.dsc

-- 
Arturo Borrero González


Reply to: