Bug#748831: RFS: crashme/2.7-1 [ITA]
> >>>If my supposition is correct, then this is a grave bug, and after it's
> >>>fixed in unstable, it should be also fixed in stable and oldstable.
>
> I've filed it as #749816.
Thanks.
>
> * Paul Wise <pabs@debian.org>, 2014-05-27, 08:43:
> >On Tue, May 27, 2014 at 1:07 AM, Dariusz Dwornikowski wrote:
> >>I can fix this when I am given DM rights to crashme.
> >Nothing about stable/oldstable updates requires DM rights, you can do that
> >through your normal sponsors.
>
> Hear, hear. Just to be clear: I am absolutely not giving anyone DM
> permissions after a single upload. :-)
>
Ack.
>
> Anyway, let's get back to work:
>
> Possible typos in the code and in the documentation:
> ntrys -> ntries
> NTRYS -> NTRIES
>
> Typo in the changelog:
> canonincal -> canonical
I fixed this by updating fix-spelling.patch.
>
> >+Description: tool to test kernel stability
>
> I think s/to test/for testing/ sounds better.
>
> >- them. Used to test kernel stability.
> >+ them. It is used to test kernel's stability.
>
> I don't think this use of 's is correct.
> As a data point, according to Google, “kernel stability” is 40 times more
> popular than “kernel's stability”.
>
> But I'm not a native speaker of English, so I might be saying nonsense here.
> If you want professional advice about your description, please ask at
> debian-l10n-english@ldo.
I followed here Don'ssuggestion.
>
> >* Added patch fixing memset transposed arguments
>
> Good catch. Please don't forget to forward the patch upstream.
Laszlo caught this but the patch was backported from 2.8.2 of crashme.
So technically upstream forwarded it to me.
>
> The following changes are not documented:
> - Upstream-Contact update in d/copyright;
> - d/crashme.install addition;
> - dropping d/crashme.lintian-overrides;
> - debian/watch update;
> - most of changes to d/rules;
> - package description updates;
> - README.debian update.
I documented it.
>
> It should be s/debian/Debian/, BTW. (Although it's not a big deal, as
> debhelper conveniently renames the file for you, so you correct correct name
> in the binary package.)
Renamed it so debhelper does not have to do it. Let's give it some
rest.
>
> I didn't get answer to my question about mprotect(2):
>
> >Shouldn't we run this code also on non-Linux architectures? At least on
> >kfreebsd-amd64, heap is not executable by default, which is what this code
> >is trying to work around.
Yes, forgot to clear this. I am not sure I fully undestand. Crashme is
built on all archs but this is probably not what you meant.
Won't this conditional catch for kfreebsd-amd64 (
defined(__FreeBSD__) compiler macro will catch it ?
--
Dariusz Dwornikowski,
Institute of Computing Science, Poznań University of Technology
www.cs.put.poznan.pl/ddwornikowski/
room 2.7.2 BTiCW | tel. +48 61 665 29 41
Reply to: