Bug#748831: RFS: crashme/2.7-1 [ITA]
> > * Copyright changed to DEP-5
>
> This is not an accurate description of changes to the copyright file. The
> original copyright file was already in the DEP-5 format.
Fixed that.
>
> > * New maintainer (Closes: #739083)
>
> Did you get any reply from George?
Yes, we talked that is why I took over the package. We have been
working on crashme (he is upstream) past few weeks.
>
> > * Hardening added
>
> That's not an accurate description of the change you did either. (Although
> enabled hardening might be a side effect of this change.)
>
> Why is override_dh_auto_build commented in debian/rules? If this code is not
> supposed to be run, then remove it.
>
> Why do you set CFLAGS in debian/rules?
Fixed. Removed.
>
> > * Spelling patch refreshed
>
> Please forward the patch upstream. There's more typos that you might want to
> fix:
>
> $ codespell --skip '*.patch'
> ./crashme.txt:26: seperate ==> separate
> ./crashme.txt:77: enviroment ==> environment
> ./crashme.html:147: exersize ==> exercise
> ./crashme.html:272: seperate ==> separate
Did that and forwarded to codeplex issue tracker.
>
> > * Bump standards to 3.9.5
>
> Did it require any changes to packaging?
Nope, fixed.
>
> > * Created manpage for pddet binary
>
> I'm sorry to say that, but this manpage is not helpful. I read it twice, and
> still have no idea what is this program supposed to do.
I found a better piece of text to put there, by upstream too.
>
> > * d/rules updated to clean cleanly
>
> If you listed files to remove in debian/clean, you could avoid the override
> in debian/rules.
Yes, fixed that too. Settled for d/rules.
>
The package is in VCS:
http://anonscm.debian.org/gitweb/?p=collab-maint/crashme.git
--
Dariusz Dwornikowski,
Institute of Computing Science, Poznań University of Technology
www.cs.put.poznan.pl/ddwornikowski/
room 2.7.2 BTiCW | tel. +48 61 665 29 41
Reply to: