[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#748476: marked as done (RFS: eggdrop/1.6.21-2)

Your message dated Mon, 19 May 2014 15:23:39 -0700
with message-id <CACZd_tDHDdGtMx6b-rwFEizQjEe-hQsLJynTS-Zzc2q0ry_aSQ@mail.gmail.com>
and subject line Re: Bug#748476: RFS: eggdrop/1.6.21-2
has caused the Debian Bug report #748476,
regarding RFS: eggdrop/1.6.21-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
748476: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=748476
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: sponsorship-requests
Severity: normal

  Dear mentors,

  I am looking for a sponsor for my package "eggdrop"

 * Package name    : eggdrop
   Version         : 1.6.21-2
   Upstream Author : EggHeads Development Team <eggheads@eggheads.org>
 * URL             : http://www.eggheads.org/
 * License         : GPL-2+
   Section         : net

  It builds those binary packages:

    eggdrop    - Advanced IRC Robot
 eggdrop-data - Architecture independent files for eggdrop

  To access further information about this package, please visit the
  following URL:

  http://mentors.debian.net/package/eggdrop


  Alternatively, one can download the package with dget using this
  command:

    dget -x
    http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-2.dsc

  More information about hello can be obtained from
  http://www.example.com.

  Changes since the last upload:

    * debian/patches/03fix_freebsd_build:
    - use $CC in SHLIB_LD (instead of hardcoded ld)


  Regards,
   Cédric Barboiron

--- End Message ---
--- Begin Message --- 
On Mon, May 19, 2014 at 11:08 AM, Cédric Barboiron <ced@winkie.fr> wrote:
> On Sun, 18 May 2014 20:03:41 -0700
> Vincent Cheng <vcheng@debian.org> wrote:
>
>
>>
>> > Well, since I've read /usr/share/doc/autotools-dev/README.Debian.gz
>> > and tried to use dh-autoreconf properly. You can find the updated
>> > package at the same place :
>> >   http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-2.dsc
>>
>> - Why does debian/control now have "Build-Conflicts: autoconf2.13,
>> automake1.4"?
>> - debian/source/options should be unnecessary (dh-autoreconf takes
>> care of removing/restoring autotools cruft before/after build)
>>
>
> For these two points I only applied autotools-dev/README (after
> learning its existence at
> https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-autotools
> ):
>
> "The autoconf2.13 package diverts autoconf, autoheader and autoreconf
> from the autoconf package to autoconf2.50, autoheader2.50 and
> autoreconf2.50. You must make sure you are not depending on the
> existence of the diverted scripts.
>
> The automake packages provide alternatives for the automake command,
> with increased priority for newer versions.  There is one exception: the
> automake1.4 package provides a higher priority alternative for the
> automake command than the newer automake packages."
>
> and
>
> "Reducing the annoyance factor with diffs:
>
> By adding a suitable extend-diff-ignore option to debian/source/options,
> one can instruct dpkg-source to ignore config.sub, config.guess, and
> any other autogenerated files (such as Makefile when autoconf is used,
> Makefile and Makefile.in when automake is used, etc).
>
> For example, you could use:
> extend-diff-ignore="(^|/)(config\.sub|config\.guess|Makefile)$"
>
> I'm not able to say if these tips should be followed in this particular
> case. Would you like me do any more changes?

Your extend-diff-ignore (in debian/source/options) is redundant given
that you use dh-autoreconf; it'll take care of cleaning and restoring
autotools cruft for you so that dpkg-source won't complain about them.
I believe that your Build-Conflicts is redundant as well...but
regardless, both of these are harmless and I only mentioned these
specific changes because they showed up in an otherwise
straight-forward debdiff.

Built, signed, and uploaded; thanks for your contribution to Debian!

Regards,
Vincent

--- End Message ---
Reply to: