Bug#748476: RFS: eggdrop/1.6.21-2
On Sat, 17 May 2014 16:02:29 -0700
Vincent Cheng <vcheng@debian.org> wrote:
> >
> > * debian/patches/03fix_freebsd_build:
> > - use $CC in SHLIB_LD (instead of hardcoded ld)
>
> Why are you patching automatically generated files (configure, in this
> case)? I'm certainly not an autotools expert, but can't you patch
> aclocal.m4 instead and then run autoreconf (or rather, use
> dh-autoreconf) afterwards?
>
Hi Vincent,
Thanks for your feedback. You're right, and indeed my first local patch
was against aclocal.m4.
But it did introduce automake + autoconf as build dependencies (we
were using upstream configure before), and was getting more complicated
than a one-line fix to build on kfreebsd. I agree that it is not a good
excuse.
Well, since I've read /usr/share/doc/autotools-dev/README.Debian.gz and
tried to use dh-autoreconf properly. You can find the updated package
at the same place :
http://mentors.debian.net/debian/pool/main/e/eggdrop/eggdrop_1.6.21-2.dsc
I successfully built it on amd64 with pbuilder and on a
fresh kfreebsd-amd64 install.
Regards
--
Cédric
Reply to: