[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#738920: RFS: obsession/20130822-1 [ITP] -- Session management helpers for lightweight desktop environments



Hi Eriberto, hi mentors,

> d/changelog: the initial realease is your first work in the package.
> So, d/changelog must have only 'Initial release (Closes: #731278)'.
done.

> d/copyright: I suggest you put all licenses grouped at the end of the
> file. This will provide a better organization.
done.

> d/docs: remove AUTHORS. The authors must be put in d/copyright only.
done.

My only definitive modifications were the creation of manpages. Since I
forwarded them to upstream, I now add them with a patch.
So, I removed the README.source

> d/rules: remove the unecessary comments, as '# -*- makefile -*-', '#
> Uncomment this to turn on verbose mode.' and '# This has to be
> exported to make some magic below work.'.
I kept the emacs-line and removed the other comments.

> I also suggest you add '--parallel' to 'dh $@'.
done.

>> - two 'I' about hardening-no-fortify-functions. I admit I haven't tried to
>> solve this one, but I'm sure tho CPPFLAGS are given to the C++ compiler.
>> So I assumed it was a false-positive.
> 
> This is the problem. :-) Generally, has a solution. Please, try here:
> 
> https://wiki.debian.org/Hardening
I made sure that the CPPFLAGS are given to the C and the C++ compilers,
but the warning remains.
Maybe a clue: the binaries produced are not PIE (but they have 'fortify
source functions').

Thanks to recent emails on d-mentors (thx ekasper for asking and bmarc
for answering), I learned that I could host a personal git repository
thanks to my alioth account. So that's what I did, so I also started
using git-buildpackage, and I added the Vcs-Git field in the control file.

The up-to-date version of the package is here:
https://mentors.debian.net/package/obsession

If anyone has more comments, please tell me.

Cheers,

Fabien


Reply to: