Bug#738920: RFS: obsession/20130822-1 [ITP] -- Session management helpers for lightweight desktop environments
Hi Fabien,
I checked your package. Note that I want help you improve your package
but I can upload it. My considerations:
d/changelog: the initial realease is your first work in the package.
So, d/changelog must have only 'Initial release (Closes: #731278)'.
d/copyright: I suggest you put all licenses grouped at the end of the
file. This will provide a better organization. See an example here:
http://sources.debian.net/src/volatility/2.3.1-7/debian/copyright
d/docs: remove AUTHORS. The authors must be put in d/copyright only.
d/patches: replicate d/changelog parts in patches headers is unusual.
Please, fix this.
d/patches/copyright: is unusual fix the copyright notices in upstream
code. I suggest to remove it.
d/README.source: must be used to list modifications that you made,
definitely, in the upstream source code. See an example here:
http://sources.debian.net/src/lime-forensics/1.1-r17%2Bdfsg-2/debian/README.source
d/rules: remove the unecessary comments, as '# -*- makefile -*-', '#
Uncomment this to turn on verbose mode.' and '# This has to be
exported to make some magic below work.'. I also suggest you add
'--parallel' to 'dh $@'.
Building, I can see some lintian warnings. Please, see
http://eriberto.pro.br/blog/?p=1289
I hope this help.
Regards,
Eriberto
Reply to: