Bug#720924: RFS: spotweb/20130826+dfsg-1~pre6 [RC]
Hi Vincent,
Thank you for your review!
debian/copyright:
- missing license entry for images/ttf/liberation-sans/* (even if you
don't ship the embedded font files, if they're in the source tarball,
they need to be acknowledged in debian/copyright)
Thanks for spotting this. An earlier version if the upstream package
shipped
non-free font files, which I had removed from the dfsg source. Looking
at
the license file in images/ttf/liberation-sans/License.txt, it looks
like these,
too, may need to be considered non-free, since it contains export
control
limitations in section 3. (these are not present in the copyright text
of the
Debian ttf-liberation font package). I can either move the license text
to
debian/copyright (including the export control limitations), or
completely
remove the font files from the dfsg source package. Which would you
advise?
- your "License: Apache-2" standalone section is incomplete; you
should include the text of Apache 2.0's Appendix (i.e. the license
header in lib/notifications/prowl/*)A
Fixed.
Nice to have:
debian/changelog: Please collapse all your newest changelogs into a
single one
Done.
debian/control: Consider depending on libapache2-mod-php5 | php5 and
php5-mysql | php5-mysqlnd
Wouldn't depending on libapache2-mod-php5 | php5 cause apt-get to allow
installing spotweb on systems having just apache2 and php5-cli?
Thanks again for your effort in reviewing this package, I had almost
given up on it!
Kind regards
Jan-Pascal
Reply to: