[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#720924: RFS: spotweb/20130826+dfsg-1~pre6 [RC]



Control: tag -1 moreinfo

Hi Jan-Pascal,

The package you've prepared looks really good overall, good job! Just
a few nitpicks:

Must-haves:

debian/copyright:
 - missing license entry for images/ttf/liberation-sans/* (even if you
don't ship the embedded font files, if they're in the source tarball,
they need to be acknowledged in debian/copyright)
 - your "License: Apache-2" standalone section is incomplete; you
should include the text of Apache 2.0's Appendix (i.e. the license
header in lib/notifications/prowl/*)

Nice to have:

debian/changelog: Please collapse all your newest changelogs into a single one
debian/control: Consider depending on libapache2-mod-php5 | php5 and
php5-mysql | php5-mysqlnd

Regards,
Vincent


Reply to: