Hi Luca,
Le mercredi, 1 janvier 2014, 20.58:02 Luca Niccoli a écrit :
> Hi Didier and Till,
>
> I'm reopening the RFS bug for splix.
I'm awfully sorry to have failed to answer you earlier, let's correct
that now.
> I've uploaded a new version of splix that merges the last upstream
> changes (mainly dropping patches that have been accepted upstream),
> sets the maintainer as the Debian Printing Team and moves the
> packaging to a git workflow.
Great!
Could you make your git repository available somewhere so that I could
review the git workflow itself too?
> You can find the dsc at
> http://mentors.debian.net/debian/pool/main/s/splix/splix_2.0.0+svn315-> 1.dsc If you are too busy I can ask my usual sponsor if he is
> available to upload it, but I think moving the package under the
> Debian Printing Team umbrella should be done by a member.
I'll make sure to make myself available enough to get that uploaded.
Now for the review:
* I find the debian/changelog entry quite messy and I do prefer to hand-
edit it after git-dch to make it less redundant and more useful to users
and other developers. In your case, at least two Standards-Version
updates are redundant, same goes for upstream imports; I would write it
that way for example:
splix (2.0.0+svn315-1) unstable; urgency=medium
* New svn upstream snapshot (revision 315)
- Add support for Samsung ML-2160 (Closes: #696240).
- Add support for Samsung ML-2165.
* Drop patches that have been merged upstream
* Add get-orig-source target to fetch recreate the tarball from
upstream SVN.
* Set debian build flags during build.
* Make build verbose to have more informative buildd logs.
* Imported existing quilt patches into gbp-pq and refreshed them for
the new upstream version.
* Fixed splix.ppd-updater, thanks to Till Kamppeter.
* Add apport hook on Ubuntu and derivatives (reduces the package
delta).
* Move package under the Debian Printing Team umbrella.
* Bump Standards-Version to 3.9.5 (no changes needed)
That's arguably a minor nitpick, but a good changelog really helps
identifying potential problems.
* Otherwise, I only see the Vcs-Git and Vcs-Browser fields missing, but
it's arguably not possible to set them before the git repository is
available. :-)
* In short; it is mostly uploadable! :-)
> Also, not being a DD I can not upload my local git repo on Alioth; it
> would be nice if someone from the team could create it for me and add
> me to the project. Cheers,
Your alioth account is lultimouomo-guest, right ? Can you request to get
added to the collab-maint alioth project as documented on
https://lists.debian.org/debian-devel-announce/2012/01/msg00006.html
? I will then request your inclusion in this (lightweight and general-
purpose) project, so that you can maintain splix as a collab-maint git
repository.
Cheers,
OdyXAttachment:
signature.asc
Description: This is a digitally signed message part.