[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#722094: RFS: avra/1.3.0-1 [ITA] -- assembler for Atmel AVR microcontrollers



On 09/08/2013 11:21 AM, Vincent Bernat wrote:
>  ❦  7 septembre 2013 22:22 CEST, Milan Kupcevic <milan@physics.harvard.edu> :
> 
>> I am looking for a sponsor for my package "avra"
>>
>>   Package name    : avra
>>   Version         : 1.3.0-1
>>   URL             : http://avra.sf.net
>>   License         : GPL-2+
>>   Section         : electronics
>>
>> It builds this binary package:
>>
>>   avra  - Assembler for Atmel AVR microcontrollers
> 
> Hi Milan!
> 

Hi Vincent:

> The package looks good.
> 
> The short description should not start with a capital (in
> debian/control).

Done.

> 
> Please, convert debian/copyright to DEP-5. This is not a mandatory step
> for Debian policy but this is something that I require to sponsor
> packages. 

Done.

> Moreover, this file is currently incomplete. You should update
> the years, add copyright information for debian/* files 

Done.

> and it seems you are not one of the copyright holders. 

Well, while transforming the package to 3.0 quilt I rewrote all the
content in almost all the files in debian/*, and added new files. There
is hardly any content left of previous maintainers. Moreover, out of
three patches I'm the author of two, and I back-ported the code from the
upstream for the third patch.

> There are some other copyright holders, like in src/device.c and examples/*.
> 
> src/stab.h is Copyright (c) 1990 by Sun Microsystems, Inc. I think it is
> not covered by GPLv2 since it was only released a year later. Its
> content is present in other headers (like <a.out.h> and <stab.h>). Since
> it is an header, it is believed that they are not copyrightable. Just
> document those facts (not copyrightable and content available in two
> other header files) to be safe.
> 

Done.


Vincent,

Thank you for quick review, quick response, and for doing this important
service for Debian. Please review the newly uploaded package again.


Milan


Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: