Bug#719207: RFS: mosquitto/1.2-1

[Roger Light <roger@atchoo.org>]

Hi Vincent,

Thanks for taking the time to carry out a review.

>  - debian/control: the dependency of libmosquitto-dev is quite odd. Why
>    not (= ${binary:Version})? I understand that you avoid to upgrade the
>    binary package if there is only packaging changes, but sometimes,
>    packaging changes contain patches or other things that could impact
>    the compatibility. Maybe this is OK, but I think this is quite
>    unusual. I would prefer that you use (= ${binary:Version}).

The reason for the odd dependency is because the -dev packages are in
arch-all. If you use (= ${binary:Version}) then the lintian error
not-binnmuable-all-depends-any occurs:
http://lintian.debian.org/tags/not-binnmuable-all-depends-any.html

I could change it to just depend on (>= ${source:Version}) if you
think that would be more appropriate.

>  - debian/copyright: as far as I know, BSD-1-clause does not exist. But
>    I suppose the name is OK and that it was already uploaded this
>    way. So no change required.

Whilst I agree that I've not really heard of it's use before, the
license here has only 1 clause:
http://troydhanson.github.io/uthash/license.html

>  - debian/rules: the invokations of PYTHON2 and PYTHON3 happen to be
>    easy to merge.

Agreed, I have changed it.

>  - debian/mosquito.init: I am not really experienced with upstart but I
>    think you should update the init script and the dependencies with the
>    information on this page:
>     https://wiki.ubuntu.com/UpstartCompatibleInitScripts

I already had a custom test along those lines, but am glad to see
there is a standard way of checking now.

I've made the changes you suggest, excluding the lib dependency
changes, and uploaded to mentors again.

Regards,

Roger