❦ 9 août 2013 11:16 CEST, Roger Light <roger@atchoo.org> :
> Package: sponsorship-requests
> Severity: normal
>
> Dear mentors,
>
> I am looking for a sponsor for my package "mosquitto"
>
> * Package name : mosquitto
> Version : 1.2-1
> Upstream Author : Roger Light <roger@atchoo.org>
> * URL : http://mosquitto.org/
> * License : BSD-3-clause
> Section : net
Hi Roger!
- debian/control: the dependency of libmosquitto-dev is quite odd. Why
not (= ${binary:Version})? I understand that you avoid to upgrade the
binary package if there is only packaging changes, but sometimes,
packaging changes contain patches or other things that could impact
the compatibility. Maybe this is OK, but I think this is quite
unusual. I would prefer that you use (= ${binary:Version}).
- debian/copyright: as far as I know, BSD-1-clause does not exist. But
I suppose the name is OK and that it was already uploaded this
way. So no change required.
- debian/postinst: I think this is too late and not worth a change,
but there is a high risk of collision with the "mosquitto"
user. There is no policy for that in Debian but some programs adopt
"Debian-mosquitto" while others "_mosquitto". I prefer the later. As
I suppose this use has already been shipped in previous versions of
the package, don't change anything.
- debian/rules: the invokations of PYTHON2 and PYTHON3 happen to be
easy to merge.
- debian/mosquito.init: I am not really experienced with upstart but I
think you should update the init script and the dependencies with the
information on this page:
https://wiki.ubuntu.com/UpstartCompatibleInitScripts
--
Use variable names that mean something.
- The Elements of Programming Style (Kernighan & Plauger)
Attachment:
signature.asc
Description: PGP signature