[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling



* Giulio Paci <giuliopaci@gmail.com>, 2013-01-30, 03:27:
To improve the manpages I improved the command line help messages (1008_improve_command_line_help.patch)

Doesn't this patch break ABI?

Speaking of which, I had a look at the list of exported symbols, and it's kinda messy... Some symbols have very generic names. Upstream should consider putting them into a namespace.

1007_escape_filename.patch
The latter fixes .bz2 handling and should work on Windows as well (although I have not tested it yet on a real Windows system).

I would be surprised if decompression worked correctly, though I don't have access to a Windows system to test it.

"^" is a cmd.exe escape character, but then the executed program does argument parsing on its own. It's usually done by the MSVC++ runtime: http://msdn.microsoft.com/en-us/library/ms880421.aspx

--
Jakub Wilk


Reply to: