Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

[Giulio Paci <giuliopaci@gmail.com>]

* Jakub Wilk <jwilk@debian.org>, 2013-01-10, 22:15:
> * Giulio Paci <giuliopaci@gmail.com>, 2013-01-08, 23:27:
>>I completed the generic implementation, added an implementation based 
>>on __builtin_clzl and implemented a selection mechanism in 
>>configure.ac.
>>The priority is:
>>x86 implementation
>>__builtin_clzl implementation
>>generic implementation
> 
> Looks good to me. (Although I suspect that the assembly implementation 
> is a case of premature optimization. Meh...)

I also suspect it is.

> The ZFile implementation worries me... Do I read it correctly that 
> filenames are passed to shell without any escaping?

Unfortunately you are right. Do you have a quick fix in mind?

> Nitpicking: in src/util/Logger.cpp:
>             printf("%.3f\t", (float)(clock() - _startTime) / CLOCKS_PER_SEC);
> A typecast to double would make more sense, as the compiler will promote 
> the resulting floating point number to double anyway. (There are more 
> similar buglets in this and other files; please grep for 
> CLOCKS_PER_SEC.)

Fixed.

Bests,
	Giulio.