Re: [PATCH 05/11] block: add a store_limit operations for sysfs entries
- To: John Garry <john.g.garry@oracle.com>
- Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>, Damien Le Moal <dlemoal@kernel.org>, Ming Lei <ming.lei@redhat.com>, Nilay Shroff <nilay@linux.ibm.com>, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, nbd@other.debian.org, linux-scsi@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, "Martin K . Petersen" <martin.petersen@oracle.com>, Johannes Thumshirn <johannes.thumshirn@wdc.com>
- Subject: Re: [PATCH 05/11] block: add a store_limit operations for sysfs entries
- From: Christoph Hellwig <hch@lst.de>
- Date: Fri, 10 Jan 2025 11:01:32 +0100
- Message-id: <[🔎] 20250110100132.GA11632@lst.de>
- In-reply-to: <[🔎] 79d85a4e-57c3-454e-a65b-d2a3764eaf0c@oracle.com>
- References: <[🔎] 20250110054726.1499538-1-hch@lst.de> <[🔎] 20250110054726.1499538-6-hch@lst.de> <[🔎] 79d85a4e-57c3-454e-a65b-d2a3764eaf0c@oracle.com>
On Fri, Jan 10, 2025 at 09:56:35AM +0000, John Garry wrote:
>> + lim->flags &= ~BLK_FLAG_IOSTATS_PASSTHROUGH;
>> + return 0;
>> }
>
> BTW, this function seems to duplicate queue_feature_store(), no?
That operates on lim->features using BLK_FEAT_* values, while
the quoted on operates on lim->flags and BLK_FLAG_*.
Reply to: