Re: [PATCH 06/10] virtio_blk: use queue_limits_commit_update_frozen in cache_type_store
- To: Damien Le Moal <dlemoal@kernel.org>
- Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>, Ming Lei <ming.lei@redhat.com>, Nilay Shroff <nilay@linux.ibm.com>, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, nbd@other.debian.org, virtualization@lists.linux.dev, linux-scsi@vger.kernel.org, usb-storage@lists.one-eyed-alien.net
- Subject: Re: [PATCH 06/10] virtio_blk: use queue_limits_commit_update_frozen in cache_type_store
- From: Christoph Hellwig <hch@lst.de>
- Date: Mon, 6 Jan 2025 16:27:48 +0100
- Message-id: <[🔎] 20250106152748.GB27431@lst.de>
- In-reply-to: <[🔎] 3cf61c5f-b53b-43b6-90de-e42272f74e3f@kernel.org>
- References: <[🔎] 20250106100645.850445-1-hch@lst.de> <[🔎] 20250106100645.850445-7-hch@lst.de> <[🔎] 07353499-b62d-488a-9575-12de5d9b6f2e@kernel.org> <[🔎] 20250106105957.GC21833@lst.de> <[🔎] 3cf61c5f-b53b-43b6-90de-e42272f74e3f@kernel.org>
On Mon, Jan 06, 2025 at 10:09:16PM +0900, Damien Le Moal wrote:
> Sounds good to me, but let's be consistent then: do not remove the
> freeze/unfreeze from virtio_blk in patch 2 and do it here in this patch.
> Otherwise, patch 2 *does* change the behavior of virtio_blk, introducing a bug
> (missing freeze around commit update).
Yeah, I'll fix it up. As mentioned in the cover letter I just brushed
this up just enough to be presentable for now.
Reply to: