Re: [PATCH 06/10] virtio_blk: use queue_limits_commit_update_frozen in cache_type_store
- To: Damien Le Moal <dlemoal@kernel.org>
- Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>, Ming Lei <ming.lei@redhat.com>, Nilay Shroff <nilay@linux.ibm.com>, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, nbd@other.debian.org, virtualization@lists.linux.dev, linux-scsi@vger.kernel.org, usb-storage@lists.one-eyed-alien.net
- Subject: Re: [PATCH 06/10] virtio_blk: use queue_limits_commit_update_frozen in cache_type_store
- From: Christoph Hellwig <hch@lst.de>
- Date: Mon, 6 Jan 2025 11:59:57 +0100
- Message-id: <[🔎] 20250106105957.GC21833@lst.de>
- In-reply-to: <[🔎] 07353499-b62d-488a-9575-12de5d9b6f2e@kernel.org>
- References: <[🔎] 20250106100645.850445-1-hch@lst.de> <[🔎] 20250106100645.850445-7-hch@lst.de> <[🔎] 07353499-b62d-488a-9575-12de5d9b6f2e@kernel.org>
On Mon, Jan 06, 2025 at 07:56:19PM +0900, Damien Le Moal wrote:
> On 1/6/25 7:06 PM, Christoph Hellwig wrote:
> > So far cache_type_store didn't freeze the queue, fix that by using the
> > queue_limits_commit_update_frozen helper.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> This should be squashed in patch 2, no ?
patch 2 is supposed to just be a mechanical conversion, and each
behavior change should be in it's own patch.
Reply to: