Re: [axboe-block:for-next] [block] 1122c0c1cc: aim7.jobs-per-min 22.6% improvement
- To: Oliver Sang <oliver.sang@intel.com>
- Cc: Christoph Hellwig <hch@infradead.org>, Christoph Hellwig <hch@lst.de>, oe-lkp@lists.linux.dev, lkp@intel.com, Jens Axboe <axboe@kernel.dk>, Ulf Hansson <ulf.hansson@linaro.org>, Damien Le Moal <dlemoal@kernel.org>, Hannes Reinecke <hare@suse.de>, linux-block@vger.kernel.org, linux-um@lists.infradead.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com
- Subject: Re: [axboe-block:for-next] [block] 1122c0c1cc: aim7.jobs-per-min 22.6% improvement
- From: Christoph Hellwig <hch@infradead.org>
- Date: Tue, 25 Jun 2024 20:39:50 -0700
- Message-id: <[🔎] ZnuNhkH26nZi8fz6@infradead.org>
- In-reply-to: <Znt4qTr/NdeIPyNp@xsang-OptiPlex-9020>
- References: <[🔎] 202406250948.e0044f1d-oliver.sang@intel.com> <[🔎] ZnqGf49cvy6W-xWf@infradead.org> <Znt4qTr/NdeIPyNp@xsang-OptiPlex-9020>
On Wed, Jun 26, 2024 at 10:10:49AM +0800, Oliver Sang wrote:
> I'm not sure I understand this test request. as in title, we see a good
> improvement of aim7 for 1122c0c1cc, and we didn't observe other issues for
> this commit.
The improvement suggests we are not sending cache flushes when we should
send them, or at least just handle them in md.
> do you mean this improvement is not expected or exposes some problems instead?
> then by below patch, should the performance back to the level of parent of
> 1122c0c1cc?
>
> sure! it's our great pleasure to test your patches. I noticed there are
> [1]
> https://lore.kernel.org/all/20240625110603.50885-2-hch@lst.de/
> which includes "[PATCH 1/7] md: set md-specific flags for all queue limits"
> [2]
> https://lore.kernel.org/all/20240625145955.115252-2-hch@lst.de/
> which includes "[PATCH 1/8] md: set md-specific flags for all queue limits"
>
> which one you suggest us to test?
> do we only need to apply the first patch "md: set md-specific flags for all queue limits"
> upon 1122c0c1cc?
> then is the expectation the performance back to parent of 1122c0c1cc?
Either just the patch in reply or the entire [2] series would be fine.
Thanks!
Reply to: