Re: [axboe-block:for-next] [block] bd4a633b6f: fsmark.files_per_sec -64.5% regression
- To: Oliver Sang <oliver.sang@intel.com>
- Cc: Christoph Hellwig <hch@lst.de>, oe-lkp@lists.linux.dev, lkp@intel.com, Jens Axboe <axboe@kernel.dk>, Damien Le Moal <dlemoal@kernel.org>, Hannes Reinecke <hare@suse.de>, linux-m68k@lists.linux-m68k.org, linux-um@lists.infradead.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com
- Subject: Re: [axboe-block:for-next] [block] bd4a633b6f: fsmark.files_per_sec -64.5% regression
- From: Christoph Hellwig <hch@lst.de>
- Date: Wed, 26 Jun 2024 08:18:04 +0200
- Message-id: <[🔎] 20240626061804.GA23481@lst.de>
- In-reply-to: <Znuw/4zMD4w5Oq2a@xsang-OptiPlex-9020>
- References: <[🔎] 202406241546.6bbd44a7-oliver.sang@intel.com> <[🔎] 20240624083537.GA19941@lst.de> <Znuw/4zMD4w5Oq2a@xsang-OptiPlex-9020>
On Wed, Jun 26, 2024 at 02:11:11PM +0800, Oliver Sang wrote:
> hi, Christoph Hellwig,
>
> On Mon, Jun 24, 2024 at 10:35:37AM +0200, Christoph Hellwig wrote:
> > This is odd to say at least. Any chance you can check the value
> > of /sys/block/$DEVICE/queue/rotational for the relevant device before
> > and after this commit? And is this an ATA or NVMe SSD?
> >
>
> yeah, as Niklas mentioned, it's an ATA SSD.
>
> I checked the /sys/block/$DEVICE/queue/rotational before and after this commit,
> both show '0'. not sure if this is expected.
>
> anyway, I noticed you send a patch [1]
>
> so I applied this patch upon bd4a633b6f, and found the performance restored.
Thanks for testing!
Reply to: