Re: [PATCH 14/14] block: add special APIs for run-time disabling of discard and friends
- To: Christoph Hellwig <hch@lst.de>
- Cc: Jens Axboe <axboe@kernel.dk>, "Martin K. Petersen" <martin.petersen@oracle.com>, Richard Weinberger <richard@nod.at>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, Johannes Berg <johannes@sipsolutions.net>, Josef Bacik <josef@toxicpanda.com>, Ilya Dryomov <idryomov@gmail.com>, Dongsheng Yang <dongsheng.yang@easystack.cn>, Roger Pau Monné <roger.pau@citrix.com>, linux-um@lists.infradead.org, linux-block@vger.kernel.org, nbd@other.debian.org, ceph-devel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>, Damien Le Moal <dlemoal@kernel.org>
- Subject: Re: [PATCH 14/14] block: add special APIs for run-time disabling of discard and friends
- From: "Martin K. Petersen" <martin.petersen@oracle.com>
- Date: Thu, 13 Jun 2024 21:49:40 -0400
- Message-id: <[🔎] yq1tthwqonx.fsf@ca-mkp.ca.oracle.com>
- In-reply-to: <20240531074837.1648501-15-hch@lst.de> (Christoph Hellwig's message of "Fri, 31 May 2024 09:48:09 +0200")
- References: <20240531074837.1648501-1-hch@lst.de> <20240531074837.1648501-15-hch@lst.de>
Christoph,
> A few drivers optimistically try to support discard, write zeroes and
> secure erase and disable the features from the I/O completion handler
> if the hardware can't support them. This disable can't be done using
> the atomic queue limits API because the I/O completion handlers can't
> take sleeping locks or freeze the queue. Keep the existing clearing of
> the relevant field to zero, but replace the old blk_queue_max_* APIs
> with new disable APIs that force the value to 0.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
Reply to: