Re: [PATCH 02/14] ubd: untagle discard vs write zeroes not support handling
- To: Christoph Hellwig <hch@lst.de>
- Cc: Jens Axboe <axboe@kernel.dk>, "Martin K. Petersen" <martin.petersen@oracle.com>, Richard Weinberger <richard@nod.at>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, Johannes Berg <johannes@sipsolutions.net>, Josef Bacik <josef@toxicpanda.com>, Ilya Dryomov <idryomov@gmail.com>, Dongsheng Yang <dongsheng.yang@easystack.cn>, Roger Pau Monné <roger.pau@citrix.com>, linux-um@lists.infradead.org, linux-block@vger.kernel.org, nbd@other.debian.org, ceph-devel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>, Damien Le Moal <dlemoal@kernel.org>
- Subject: Re: [PATCH 02/14] ubd: untagle discard vs write zeroes not support handling
- From: "Martin K. Petersen" <martin.petersen@oracle.com>
- Date: Thu, 13 Jun 2024 21:36:04 -0400
- Message-id: <[🔎] yq1r0d0tifi.fsf@ca-mkp.ca.oracle.com>
- In-reply-to: <20240531074837.1648501-3-hch@lst.de> (Christoph Hellwig's message of "Fri, 31 May 2024 09:47:57 +0200")
- References: <20240531074837.1648501-1-hch@lst.de> <20240531074837.1648501-3-hch@lst.de>
Christoph,
> Discard and Write Zeroes are different operation and implemented
> by different fallocate opcodes for ubd. If one fails the other one
> can work and vice versa.
>
> Split the code to disable the operations in ubd_handler to only
> disable the operation that actually failed.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
Reply to: