Re: Fixes after static code analysis
Hi Lukasz,
On Thu, Feb 22, 2024 at 12:34:58PM +0100, Lukasz Stelmach wrote:
> Hello Wouter,
>
> It was <2024-02-20 wto 14:06>, when Wouter Verhelst wrote:
> > I finally had time to have a look at your patches. Unfortunately, they
> > break the test suite; if you run "make check", the result is fairly
> > depressing :)
> >
> > Can you have a look at what's going wrong?
>
> I "fixed" one too many memory leaks reported by Coverity. I'd reverted[1]
> it and it helped
>
> --8<---------------cut here---------------start------------->8---
> $ make check
> make check-recursive
> […]
> ==================
> All 5 tests passed
> ==================
> […]
> ../inetd
> Error: inetd mode not supported without syslog support
> SKIP: inetd
> […]
> ====================
> All 18 tests passed
> (1 test was not run)
> ====================
> --8<---------------cut here---------------end--------------->8---
Thanks.
I've merged your branch, but removed those two commits (the original and
the revert).
> >> PS. I received thee more bug reports to handle. I'll review them when I
> >> get back from FOSDEM, so you don't need to hurry with these.
>
> Below the revert there are two more commits ("Fix out-of-bounds access")
> I created after 2c54e25b0c we talked about last time.
>
> [1] https://git.tizen.org/cgit/platform/upstream/nbd/log/?id=9e25a075173345410de58ac9406a464fce929531
These were merged too.
--
w@uter.{be,co.za}
wouter@{grep.be,fosdem.org,debian.org}
I will have a Tin-Actinium-Potassium mixture, thanks.
Reply to: