Re: [PATCH 0/5] block/drivers: don't clear the flag that is not set
- To: Chaitanya Kulkarni <kch@nvidia.com>, linux-block@vger.kernel.org, linux-bcache@vger.kernel.org
- Cc: josef@toxicpanda.com, minchan@kernel.org, senozhatsky@chromium.org, colyli@suse.de, kent.overstreet@gmail.com, dlemoal@kernel.org, johannes.thumshirn@wdc.com, bvanassche@acm.org, vincent.fu@samsung.com, akinobu.mita@gmail.com, shinichiro.kawasaki@wdc.com, nbd@other.debian.org
- Subject: Re: [PATCH 0/5] block/drivers: don't clear the flag that is not set
- From: Jens Axboe <axboe@kernel.dk>
- Date: Mon, 24 Apr 2023 10:39:30 -0600
- Message-id: <[🔎] 17f55b16-cc5f-a585-baa3-2a39cb5e9cf3@kernel.dk>
- In-reply-to: <20230424073023.38935-1-kch@nvidia.com>
- References: <20230424073023.38935-1-kch@nvidia.com>
On 4/24/23 1:30?AM, Chaitanya Kulkarni wrote:
> Hi,
>
> The drivers in this patch-series tries to clear the
> QUEUE_FLAG_ADD_RANDOM that is not set at all in the queue allocation
> and initialization path in :-
Just roll this into one, as it should be a non-functional change since
we don't default to ADD_RANDOM with MQ ops. And then change the title to
something meaningful, ala:
block/drivers: remove dead clear of QUEUE_FLAG_ADD_RANDOM
or something like that, as your title currently makes very little sense
(eg it's hard to parse and it doesn't really say what is being done).
--
Jens Axboe
Reply to: