Re: [PATCH 0/5] block/drivers: don't clear the flag that is not set
- To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
- Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>, "linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>, "axboe@kernel.dk" <axboe@kernel.dk>, "josef@toxicpanda.com" <josef@toxicpanda.com>, "minchan@kernel.org" <minchan@kernel.org>, "senozhatsky@chromium.org" <senozhatsky@chromium.org>, "colyli@suse.de" <colyli@suse.de>, "kent.overstreet@gmail.com" <kent.overstreet@gmail.com>, "dlemoal@kernel.org" <dlemoal@kernel.org>, "johannes.thumshirn@wdc.com" <johannes.thumshirn@wdc.com>, "bvanassche@acm.org" <bvanassche@acm.org>, "vincent.fu@samsung.com" <vincent.fu@samsung.com>, "akinobu.mita@gmail.com" <akinobu.mita@gmail.com>, "shinichiro.kawasaki@wdc.com" <shinichiro.kawasaki@wdc.com>, "nbd@other.debian.org" <nbd@other.debian.org>, "Jason@zx2c4.com" <Jason@zx2c4.com>
- Subject: Re: [PATCH 0/5] block/drivers: don't clear the flag that is not set
- From: Nitesh Shetty <nj.shetty@samsung.com>
- Date: Mon, 24 Apr 2023 16:10:46 +0530
- Message-id: <[🔎] 20230424104046.GA17688@green245>
- In-reply-to: <[🔎] 86043b4b-0960-215f-17a7-4c1facdb0713@nvidia.com>
- References: <20230424073023.38935-1-kch@nvidia.com> <CGME20230424092940epcas5p3407002e7d5c79593ffbafc38f2b49e51@epcas5p3.samsung.com> <[🔎] 20230424092641.u6u25eyojewvasj4@green245> <[🔎] 86043b4b-0960-215f-17a7-4c1facdb0713@nvidia.com>
On Mon, Apr 24, 2023 at 10:25:34AM +0000, Chaitanya Kulkarni wrote:
> On 4/24/23 02:26, Nitesh Shetty wrote:
> > On 23/04/24 12:30AM, Chaitanya Kulkarni wrote:
> >> null_blk
> >> brd
> >> nbd
> >> zram
> >> bcache
> >
> > Any particular reason for leaving out mtip and s390 drivers ?
> >
>
> I didn't find why this flag is clear at first place,
> if this gets accepted I'll others gradually..
>
> > Will it be better to use the flag similar to scsi devices and
> > use it for random number generation ?
> >
>
> I didn't understand this comment.
>
My bad. I intended, may be we can set QUEUE_FLAG_ADD_RANDOM flag.
Similar to scsi once the request completes, using function
add_disc_randomness() random generator can be updated.
Regards,
Nitesh Shetty
Reply to: