Re: [PATCH 0/9] Add data to datalog, add replay tool, V03

[Wouter Verhelst <w@uter.be>]

Hi Manfred,

On Fri, Jan 21, 2022 at 06:57:02PM +0100, Manfred Spraul wrote:
> Hi,
> 
> Updated series.
> New is:
> - Patch 0004: Update proto.md
> - Patch 0009: An initial man page.
> 
> Review feedback is welcome!

I had a detailed look today, but didn't have any further feedback.

> And: What else is needed for a new tool?
> Should I try to create a test case?

A new test case might be useful, yes.

Note that there are two (somewhat old by now) transaction logs in
tests/run ("integrity-test.tr" and "integrityhuge-test.tr") that you
might want to look at.

It could be useful to update nbd-tester-client to also support the new
transaction log format. Currently we just write zeroes, which works but
is not ideal; with actual data we might be able to compare checksums etc
afterwards.

-- 
     w@uter.{be,co.za}
wouter@{grep.be,fosdem.org,debian.org}