Re: [PATCH 2/9] nbd-server, nbd-trdump: Add support for logging actual data
- To: Manfred Spraul <manfred@colorfullife.com>
- Cc: nbd@other.debian.org, Eric Blake <eblake@redhat.com>, Manfred Spraul <manfred.spraul@de.bosch.com>
- Subject: Re: [PATCH 2/9] nbd-server, nbd-trdump: Add support for logging actual data
- From: Wouter Verhelst <w@uter.be>
- Date: Thu, 3 Mar 2022 11:35:50 +0200
- Message-id: <YiCL9iQWk06/AuGZ@pc181009.grep.be>
- In-reply-to: <YiCLt2SL/Dc4f4Mt@pc181009.grep.be>
- References: <20220121175711.5083-1-manfred@colorfullife.com> <20220121175711.5083-3-manfred@colorfullife.com> <YiCLt2SL/Dc4f4Mt@pc181009.grep.be>
On Thu, Mar 03, 2022 at 11:34:47AM +0200, Wouter Verhelst wrote:
> This feels like overkill to me.
>
> We might want a mutex just so that multiple writes handled on multiple
> threads don't corrupt the file (I don't know whether that's the case
> currently), but beyond that I don't think it's worth the extra effort.
nvm, I see you already did that in the next patch. Ignore.
--
w@uter.{be,co.za}
wouter@{grep.be,fosdem.org,debian.org}
Reply to: