[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] [PATCH] Swap options and option name

On Mon, Apr 17, 2017 at 10:57:39AM -0500, Eric Blake wrote:
> On 04/16/2017 04:42 AM, Wouter Verhelst wrote:
> > Hi Eric,
> > 
> > Side note:
> > 
> > On Fri, Apr 14, 2017 at 01:03:00PM -0500, Eric Blake wrote:
> >> I'm so glad my patches for NBD_OPT_GO didn't make it into qemu 2.9 (due
> >> to be released later this month).
> > 
> > Can you tell me where these are? I'd like to check my code against yours.
> Last posted here to the qemu list (prior to your definition swap):
> https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg04528.html
> Maintained here, although I will be doing non-fast-forward rebases from
> time to time before posting back to the qemu list (but the swap HAS been
> made if you pull from there today):
> http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/nbd
> git fetch git://repo.or.cz/qemu/ericb.git nbd

Thanks. I already managed to find an (unrelated) bug by exposing my code
to yours :-)

Side note though, while checking my OPT_INFO implementation, I
encountered a problem. I ran your qemu-nbd like so:

./qemu-nbd -x foo -D "test image" -t -p 18909 test.img

and then ran my nbd-client against it several times. At one point, I got
a SIGPIPE, because of:

qemu-nbd: io/channel.c:306: qio_channel_yield: Assertion `!ioc->read_coroutine' failed.

this was during a debugging session, so there have been a few times where
I hit "k" in gdb, so the client was killed and the socket aborted. I'm
not sure whether that's related, but it could be -- and I thought you'd
want to know this.

I haven't been able to reproduce this either, so it might be something

< ron> I mean, the main *practical* problem with C++, is there's like a dozen
       people in the world who think they really understand all of its rules,
       and pretty much all of them are just lying to themselves too.
 -- #debian-devel, OFTC, 2016-02-12

Reply to: