Re: [Nbd] [PATCH] Swap options and option name
- To: Eric Blake <eblake@...696...>
- Cc: email@example.com
- Subject: Re: [Nbd] [PATCH] Swap options and option name
- From: Wouter Verhelst <w@...112...>
- Date: Fri, 21 Apr 2017 09:17:35 +0200
- Message-id: <20170421071735.2mvbxl4di3q5vr6j@...3...>
- In-reply-to: <16cb07fc-0432-b251-c756-cada111dac0c@...696...>
- References: <20170414124637.lloiojthqzpiilty@...3...> <596b5e4f-16c8-b010-dd15-06933e9d93e6@...696...> <20170416094239.dyztgcneb6h26tuo@...3...> <16cb07fc-0432-b251-c756-cada111dac0c@...696...>
On Mon, Apr 17, 2017 at 10:57:39AM -0500, Eric Blake wrote:
> On 04/16/2017 04:42 AM, Wouter Verhelst wrote:
> > Hi Eric,
> > Side note:
> > On Fri, Apr 14, 2017 at 01:03:00PM -0500, Eric Blake wrote:
> >> I'm so glad my patches for NBD_OPT_GO didn't make it into qemu 2.9 (due
> >> to be released later this month).
> > Can you tell me where these are? I'd like to check my code against yours.
> Last posted here to the qemu list (prior to your definition swap):
> Maintained here, although I will be doing non-fast-forward rebases from
> time to time before posting back to the qemu list (but the swap HAS been
> made if you pull from there today):
> git fetch git://repo.or.cz/qemu/ericb.git nbd
Thanks. I already managed to find an (unrelated) bug by exposing my code
to yours :-)
Side note though, while checking my OPT_INFO implementation, I
encountered a problem. I ran your qemu-nbd like so:
./qemu-nbd -x foo -D "test image" -t -p 18909 test.img
and then ran my nbd-client against it several times. At one point, I got
a SIGPIPE, because of:
qemu-nbd: io/channel.c:306: qio_channel_yield: Assertion `!ioc->read_coroutine' failed.
this was during a debugging session, so there have been a few times where
I hit "k" in gdb, so the client was killed and the socket aborted. I'm
not sure whether that's related, but it could be -- and I thought you'd
want to know this.
I haven't been able to reproduce this either, so it might be something
< ron> I mean, the main *practical* problem with C++, is there's like a dozen
people in the world who think they really understand all of its rules,
and pretty much all of them are just lying to themselves too.
-- #debian-devel, OFTC, 2016-02-12