[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] [PATCH v2] doc: Add new NBD_REP_INFO reply, for advertising block size



On 13 Apr 2016, at 15:51, Eric Blake <eblake@...696...> wrote:

> On 04/13/2016 05:41 AM, Alex Bligh wrote:
>> 
>> On 13 Apr 2016, at 12:05, Alex Bligh <alex@...872...> wrote:
>> 
>>>> Having a default for preferred block size sounds sane, although it might
>>>> be better to switch it to 4096 (which is what most conversations seem to
>>>> use today) rather than 512.
>>> 
>>> +1
>> 
>> Actually doubly +1, as this in theory allows for O_DIRECT type optimisation
>> with 4k page sizes.
> 
> Telling clients to use a default preferred size of 64k (rather than 4k)
> is still nice for O_DIRECT optimizations.

Sure. Default preferred size a *minimum* of 4k. I think Wouter is
saying it shouldn't be 512.

--
Alex Bligh




Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail


Reply to: